jeff-regier / Celeste.jl

Scalable inference for a generative model of astronomical images
MIT License
183 stars 28 forks source link

add structure for supporting DECALS dataset #731

Closed kbarbary closed 6 years ago

kbarbary commented 6 years ago

In my previous PRs, I laid the groundwork for supporting general (non-SDSS) datasets, by making an interface where Celeste creates a SurveyDataSet object describing how the data is stored, and then calling load_images(dataset, box) and expecting to get back an array of survey-agnostic Celeste.Image objects containing image data. The SDSS data I/O routines now conform to this interface.

This PR lays out implementing load_images for a new SurveyDataSet type, called DECALSDataSet, which represents data from the Dark Energy Camera Legacy Survey. It goes as far as determining which images overlap the given bounding box, but does not yet load them.

The remaining to-dos to actually load the images are fairly straight-forward, but I don't know when I'm going to have time to implement them so I'm handing this off now. Most of the hard part is figuring out where the raw and calibrated images are actually located.

Here are the remaining to-do items (also commented in the code itself):

jeff-regier commented 6 years ago

Nice work Kyle! Looks like some problem with a unit test---probably something small since it ran for 11 minutes before the error.

kbarbary commented 6 years ago

Looks like the error is due to some dependencies shifting beneath us.