search

jeff-regier / Celeste.jl

Scalable inference for a generative model of astronomical images
MIT License
183 stars 28 forks source link

Reproducibility #734

Closed andymiller closed 6 years ago

andymiller commented 6 years ago

Adds experiments/mcmc_scripts directory containing all scripts needed to run MCMC-AIS experiment code.

codecov[bot] commented 6 years ago

Codecov Report

Merging #734 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   80.99%   80.99%           
=======================================
  Files          40       40           
  Lines        4025     4025           
=======================================
  Hits         3260     3260           
  Misses        765      765

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98db10e...b6a4f01. Read the comment docs.

jeff-regier commented 6 years ago

Looks good Andy. Will you add some command to the MCMC sections of sdss.ipynb and the synthetic.ipynb notebook showing how to run the scripts?

andymiller commented 6 years ago

I added sections to sdss.ipynb and synthetic.ipynb on how to run the MCMC scripts and made sure the run_celeste_on_field_mcmc.jl script is up to date.

You might want to re-run sdss.ipynb and synthetic.ipynb to get the proper output (I couldn't edit the notebook using my cori installation, and my local Celeste.jl installation (where the notebook is running) is not up to date.