search

jeff-regier / Celeste.jl

Scalable inference for a generative model of astronomical images
MIT License
183 stars 28 forks source link

Celeste relies on case-insensitive names of columns #737

Closed giordano closed 3 years ago

giordano commented 5 years ago

In FITSIO.jl we changed the default behavior of fits_get_colnum to be case-sensitive (see https://github.com/JuliaAstro/FITSIO.jl/issues/98 and https://github.com/JuliaAstro/FITSIO.jl/issues/99), but this can be controlled with the new case_sensitive keyword to fits_get_colnum and read.

Celeste.jl relies on the old case-insensitive behavior and in src/SDSSIO.jl it asks for the "rnrow" column while its actual name is "RNROW". Similarly for other columns. See https://github.com/JuliaLang/METADATA.jl/pull/18001

I see the following options:

  1. Use the column names with the proper capitalization. We should hope that all files are consistent
  2. Require the new version of FITSIO.jl and use case_sensitive=false
  3. Set an upper bound to the required version of FITSIO.jl and do nothing else.
giordano commented 3 years ago

Fixed by https://github.com/jeff-regier/Celeste.jl/commit/41c4897dde496ce5a8593593670d2e798a2a6076