search

jeff-regier / KillerAsteroids.jl

Detects asteroids that might kill us
Other
0 stars 1 forks source link

refactored code, added time to the model, added unit tests #6

Closed jeff-regier closed 9 years ago

jeff-regier commented 9 years ago

Hi Aaron, I divided bin/detect_2005UT453.jl into unit tests, since we were basically using it for testing anyway. I also refactored the code in preparation for adding time to the model.

jeff-regier commented 9 years ago

Would you try putting whatever subset of the data from the WISE_ETC directory we need into the dat directory, and comment in the problematic test? (It's in test/runtests.jl.) Thanks!

jeff-regier commented 9 years ago

The time the image was taken is in the model now. Once we decide whether to treat pixel values as Poisson or Gaussian, I think we should be all set to detect asteroid 2005_UT453.

ameisner commented 9 years ago

Hi Jeff,

Thanks for doing all of this work. I've created trimmed versions of the PSF files that amount to ~0.6 MB of data. I'm just trying to make sure I figure out how to properly add commits to this PR, since I'm not sure I've done that before.

-Aaron

jeff-regier commented 9 years ago

Hey Aaron, If it's easier, you could just merge this pull request and start a new one for the commented-out unit test...either way.

On Tue, Sep 15, 2015 at 2:40 PM Aaron Meisner notifications@github.com wrote:

Hi Jeff,

Thanks for doing all of this work. I've created trimmed versions of the PSF files that amount to ~0.6 MB of data. I'm just trying to make sure I figure out how to properly add commits to this PR, since I'm not sure I've done that before.

-Aaron

— Reply to this email directly or view it on GitHub https://github.com/jeff-regier/KillerAsteroids.jl/pull/6#issuecomment-140554908 .

ameisner commented 9 years ago

I just pushed a commit to the image_time branch and it's showing up in this PR, so I think we're good, assuming the unit tests pass now.

jeff-regier commented 9 years ago

Looks good!