search

jeff-zucker / solid-auth-cli

a node/command-line Solid client with persistent login
MIT License
10 stars 8 forks source link

Use cross-fetch instead of isomorphic-fetch #5

Closed Otto-AA closed 4 years ago

Otto-AA commented 4 years ago

Fixes #4

I ran the automated tests and actually more passed with cross-fetch (17/18 for https), than with isomorphic-fetch (14/18 for https). I'm not sure, why exactly this happens, but I guess that's ok.

Otto-AA commented 4 years ago

If solid-auth-cli is also used in the browser, I'd suggest to test it there too. But you probably know better how you test it there what you want to test it for.

jeff-zucker commented 4 years ago

If solid-auth-cli is also used in the browser, I'd suggest to test it there too. But you probably know better how you test it there what you want to test it for.

Nope, solid-auth-cli is exclusively for command line and nodejs use, it is not usable in a browser AFAIK.