search

jeff1evesque / machine-learning

Web-interface + rest API for classification and regression (https://jeff1evesque.github.io/machine-learning.docs)
Other
257 stars 85 forks source link

Create AdaBoost Wrapper (Classifier) #3049

Closed protojas closed 7 years ago

protojas commented 7 years ago

Create a python function for the ada boost classifier methods which supports SVC, KNN, RF, and normal decision trees.

ghost commented 7 years ago

Your issue doesn't follow our guidelines. Please fix the following:

Click here for details.

Thank you! :pray: This comment was made by GitMagic – Magically enforcing your contribution guidelines.

ghost commented 7 years ago

Thank you, everything looks good now! :bowtie:

jeff1evesque commented 7 years ago

@protojas keep your commit messages under 55 characters, it's going to break the checks during PR's.

jeff1evesque commented 7 years ago

Can you adjust the committed files in this issue to be similar notation to bagger.py. Also, try to keep the commit message under 55 characters, otherwise, it will break the gitmagic checker during PR. I can fix your current commit messages when it comes to the PR. But, it gets tedious if i have to fix every commit message.

protojas commented 7 years ago

ok will do

protojas commented 7 years ago

whoops I think I went over 55 characters

jeff1evesque commented 7 years ago

You can submit a PR on this request if it's ready. Otherwise, I'd have to git pull from your fork to submit a PR. Remember to have the PR merge into milestone-0.9:

merge

protojas commented 7 years ago

how do I do a pull request to milestone-0.9 again?

jeff1evesque commented 7 years ago

You do it through the web browser, a link on the top labelled 'Pull Request'. Don't git merge manually.

jeff1evesque commented 7 years ago

I've closed the corresponding pull request via https://github.com/jeff1evesque/machine-learning/pull/3077.