search

jeffalo / my-ocular

backend for ocular
https://ocular.jeffalo.net/docs/about#what-iswas-my-ocular
9 stars 10 forks source link

Switch to Scratch Auth #31

Closed Mbrick2 closed 2 years ago

Mbrick2 commented 2 years ago

FluffyScratch is currently down so this could be useful because @hamptonmoore said he doesn't have time to fix it. Here is more info I have not done any testing yet

Looky1173 commented 2 years ago

@jeffalo You might want to consider merging this pull request to avoid unnecessary redirects. Also, it seems like FluffyScratch stopped redirecting to Scratch Auth and instead returns a 502 Bad Gateway error. You can always revert a merged pull request if you change your mind.

jeffalo commented 2 years ago

Thank you. I will take a look when I get some time. :)

Looky1173 commented 2 years ago

@jeffalo People are complaining on Ocular's forum topic about not being able to sign in. This is because FluffyScratch fails to redirect to Scratch Auth for some reason. Merging this PR would fix this. I understand that you don't have much time to work on Ocular but this PR literally only changes the URL which my-ocular makes auth requests to; there's nothing to review here!

jeffalo commented 2 years ago

Thanks. I haven't been able to reproduce any issues with Fluffyscratch, but this should probably avoid them.

Looky1173 commented 2 years ago

@jeffalo Thank you for merging the PR! Also, have you restarted the my-ocular server yet (as the changes do not seem to be live as of now)?

jeffalo commented 2 years ago

Just restarted it now :)

jeffalo commented 2 years ago

Reverting because it looks like it's redirecting to localhost for some reason.

Looky1173 commented 2 years ago

@jeffalo My suggested change fixes the incorrect redirect. I think as the owner of the repo you can accept the suggestion with a click. :-)

Looky1173 commented 2 years ago

Hi @jeffalo, any updates? :-D My suggested change resolves the issue with the redirect. I can't wait to sign into Ocular once you switch to Scratch Auth!

Looky1173 commented 2 years ago

Hello @jeffalo, sorry for bothering you with the comments above, I just saw on wasteof that you are on a trip! Enjoy the journey! 🙂

Weredime commented 2 years ago

unsolicited chat link

@Looky1173 Probably you shouldn't reference this as it breaks community guidelines and this repository is linked to on scratch

Looky1173 commented 2 years ago

@Weredime Well, the name of the site is the same as its domain name... Anyway, I edited my post to not contain the direct URL.

Looky1173 commented 2 years ago

Hello @jeffalo, I hope you had a pleasant trip. Could you please take a look at my suggested fix?