search

jeffalo / my-ocular

backend for ocular
https://ocular.jeffalo.net/docs/about#what-iswas-my-ocular
9 stars 10 forks source link

better to string checks #37

Closed Weredime closed 2 years ago

Weredime commented 2 years ago

fixes https://discord.com/channels/751206349614088204/755131743136383107/992879637669609484

jeffalo commented 2 years ago

we don't really need to make sure admin input is a boolean (although i guess it's nice to have)..

is .toString not as good as String()?

Weredime commented 2 years ago

we don't really need to make sure admin input is a boolean (although i guess it's nice to have)..

is .toString not as good as String()?

toString can be set to null and then the server tries to call toString on an object which toString is manually set to null by the client "hijacker"

jeffalo commented 2 years ago

sounds good, thanks!