search

jeffalo / scratch-image-uploader

Use Scratch project thumbnails to upload images to be used on the forums.
10 stars 3 forks source link

Show more progress data #11

Closed BoomerScratch closed 4 years ago

BoomerScratch commented 4 years ago

Resolves #10 Adds "Reading file...", "Creating project...", "Naming project...", "Uploading thumbnail..." and "Moving project to trash...".

jeffalo commented 4 years ago

it doesn't seem to be working for me. image

BoomerScratch commented 4 years ago

@JeffaloBob Hmm... That's weird... Let me check.

jeffalo commented 4 years ago

@JeffaloBob Hmm... That's weird... Let me check.

thanks

BoomerScratch commented 4 years ago

@JeffaloBob It works as expected for me. I'm using a userscript.

BoomerScratch commented 4 years ago

I'm gonna try something else.

jeffalo commented 4 years ago

@JeffaloBob It works as expected for me. I'm using a userscript.

hmmm i'll see if i can fix it

jeffalo commented 4 years ago

I'm gonna try something else.

oh alright

BoomerScratch commented 4 years ago

@JeffaloBob Can you try again now? I pushed a new commit.

jeffalo commented 4 years ago

alright i'll test it

jeffalo commented 4 years ago

image atleast, it's a new error this time...

jeffalo commented 4 years ago

i'll see if i can fix it

BoomerScratch commented 4 years ago

The variable is undefined, and I don't know why.

jeffalo commented 4 years ago

The variable is undefined, and I don't know why.

thats really odd

jeffalo commented 4 years ago

ok, i have a really simple version of this working, but i have a question about the percentage when uploading thumbnail.

does it ever show anything other than 0 or 100? perhaps my images are too small or something but i cant get it to show anything in between.

BoomerScratch commented 4 years ago

@JeffaloBob Yes. If you upload a bigger image you might be able to see it.

jeffalo commented 4 years ago

@JeffaloBob Yes. If you upload a bigger image you might be able to see it.

yep! i was about to edit my comment. i slowed down my connection and i saw it.

thanks though! i'll close this PR and add my changes in a min. :)

BoomerScratch commented 4 years ago

@JeffaloBob k. I don't know what is going wrong. Maybe declare the variable with let?

jeffalo commented 4 years ago

@JeffaloBob k. I don't know what is going wrong. Maybe declare the variable with let?

yeah there something weird happening, my fix was basic and it's missing some error handling but that can be added later i guess ¯_(ツ)_/¯