search

jeffalo / scratch-image-uploader

Use Scratch project thumbnails to upload images to be used on the forums.
10 stars 3 forks source link

error handling #12

Closed jeffalo closed 4 years ago

jeffalo commented 4 years ago

handle errors better, especially with the progress thing because if theres an error thats not with the thumbnail setting (so like an error with creating a project or setting the title) the progress display will just be stuck on the step and theres not much user feedback that an error occured.

so im thinking this would go well with #9

BoomerScratch commented 4 years ago

Should I do this? Also something else: https://github.com/JeffaloBob/scratch-image-uploader/commit/1894a0d0585310b7e461bef9e2b67a09df86fd98#commitcomment-40912614

jeffalo commented 4 years ago

Should I do this?

i'll try first because i think i know how to maybe do it but if i can't figure it out then sure

BoomerScratch commented 4 years ago

@JeffaloBob Okay. Hint: use .catch() for fetch. Also, do you know you can use Fix #ISSUENUMBER (replacing ISSUENUMBER with the number of an issue) in a commit message? That will close an issue when you commit.

jeffalo commented 4 years ago

@JeffaloBob Okay. Hint: use .catch() for fetch.

yep thanks!

jeffalo commented 4 years ago

@BoomerScratch i cant get my error catching to work.. is it ok if you do this one? 😅

BoomerScratch commented 4 years ago

@JeffaloBob Sure! Let me clone the repository and do stuff after...

jeffalo commented 4 years ago

ok thanks!

BoomerScratch commented 4 years ago

@JeffaloBob Pull request created! #14