search

jeffalo / scratch-image-uploader

Use Scratch project thumbnails to upload images to be used on the forums.
10 stars 3 forks source link

cannot upload the same image using the upload button twice #13

Closed jeffalo closed 4 years ago

jeffalo commented 4 years ago

i noticed that you cant upload the same image using the upload button twice.

steps to repro: press upload button select image wait press upload button select the same image nothing happens. (no errors as well)

i think this might be an issue with chrome but maybe there's something that actually isn't working

jeffalo commented 4 years ago

oh, it's a chrome thing. https://stackoverflow.com/questions/9155136/chrome-file-upload-bug-on-change-event-wont-be-executed-twice-with-the-same-fi

theres a fix there its jquery but basically all that has to be done is clearing the value after a file is uploaded

BoomerScratch commented 4 years ago

@JeffaloBob Yes, when you upload the same file twice onchange doesn't fire. It's hard to fix, though. Also, take a look at #14 😉

jeffalo commented 4 years ago

@JeffaloBob Yes, when you upload the same file twice onchange doesn't fire. It's hard to fix, though. Also, take a look at #14 😉

thanks! i just submitted a fix for this and it seems to work for me. does it work for you?

jeffalo commented 4 years ago

i'll close this issue since i think it's fixed