search

jeffalo / scratch-image-uploader

Use Scratch project thumbnails to upload images to be used on the forums.
10 stars 3 forks source link

Add visual feedback for drag and drop #17

Closed BoomerScratch closed 4 years ago

BoomerScratch commented 4 years ago

Resolves #15 The text area will become grey when dragged over. Adding text telling the user to drag and drop was hard, so I skipped it.

jeffalo commented 4 years ago

thanks! but when i drag in an image instead of uploading it it opens it in a new tab. maybe there needs to be a e.preventDefault()somewhere?

BoomerScratch commented 4 years ago

@JeffaloBob Is it fixed now?

jeffalo commented 4 years ago

yep! awesome thanks!

jeffalo commented 4 years ago

i wonder if they are any downsides to setting an attribute instead of using css or something. i guess we'll see lol