search

jeffalo / scratch-image-uploader

Use Scratch project thumbnails to upload images to be used on the forums.
10 stars 3 forks source link

Fix drag&drop #24

Open NoobTracker opened 4 years ago

NoobTracker commented 4 years ago

A problem I have is that drag&drop isn't working. I just get that "You can't drop files here" symbol thingy when I wanna do exactly that. I'm using Firefox.

BoomerScratch commented 4 years ago

I'm on Windows 10 Chrome, and it works fine.

NoobTracker commented 4 years ago

@BoomerScratch Can you try it with the userscript instead of the Chrome thingy?

BoomerScratch commented 4 years ago

@NoobTracker I already use the userscript.

jeffalo commented 4 years ago

firefox doesn't support the web api thats used for drag and drop i think

jeffalo commented 4 years ago

are there any errors @NoobTracker ?

NoobTracker commented 4 years ago

@JeffaloBob Errors, you mean when I open the console? Let me check that ... (btw, I'm sure that Firefox supports the drag&drop event.preventDefault(); thing, I messed with that stuff a year ago)

NoobTracker commented 4 years ago

@BoomerScratch Ah.

jeffalo commented 4 years ago

yes console errors

NoobTracker commented 4 years ago

I don't think so ...

NoobTracker commented 4 years ago

Nope.

NoobTracker commented 4 years ago

@JeffaloBob No errors, and also no errors when I try to drop something.

NoobTracker commented 4 years ago

Wait, don't you also need preventDefault when you hover over the input?

NoobTracker commented 4 years ago

@JeffaloBob I think that the lack of preventDefault is the reason and Chrome may handle that differently but currently my scratch accounts are blocked so I can't check it. (jeff, it would be great if you could enable the chat, I just get a 522)

NoobTracker commented 4 years ago

@JeffaloBob Bump?

NoobTracker commented 4 years ago

What was that?

NoobTracker commented 4 years ago

So, should I just make a PR with ondragover?