jeffalo / scratch-image-uploader

Use Scratch project thumbnails to upload images to be used on the forums.
10 stars 3 forks source link

❗ the future of this extension #25

Open jeffalo opened 4 years ago

jeffalo commented 4 years ago

this was a very cool extension to make and share, but i think it would be better for development and user experience for this to be part of a larger extension.

the advantages of using that:

disadvantages

the options

i think this should be discussed since it's pretty important

NoobTracker commented 4 years ago

I think that that's a pretty good idea ... although that large extension, whatever the features there are, has only 15 stars and this one 11 so I dunno ... still, looks like that has more users. I think that it would make sense.

jeffalo commented 4 years ago

@NoobTracker from what i've heard they plan on rebranding a huge scratch related extension (1k+ users) to ScratchAddons and making it into basically the place to get smaller scratch addons

NoobTracker commented 4 years ago

That sounds awesome! Dozens of small extensions that make Scratch a little bit cooler but all together a lot cooler! And improving the code is never bad.

jeffalo commented 4 years ago

@NoobTracker yep! that's why i think that project is super cool. (plus the people working on it are very smart)

NoobTracker commented 4 years ago

But I'm not sure ... it could get a bit messy. Would every extension stay its own repository? If not, then it could get really messy when you try to discuss 50 things in one place.

NoobTracker commented 4 years ago

But if every extension stays its own thingy and every PR would just also be added to the big thing, then it could work, I think.

jeffalo commented 4 years ago

@NoobTracker yeah, i guess we'll have to wait and see how that goes.

NoobTracker commented 4 years ago

So what are the features of the extensions in the big extension so far?

NoobTracker commented 4 years ago

There could also be a script that adds a function for thumbnail and assets uploads so you can create code that does that easier and it would also be less messy.

NoobTracker commented 4 years ago

Overall it sounds pretty good. And I guess PRs still work.

NoobTracker commented 4 years ago

@JeffaloBob btw, it may be a good idea to split content.js into content.js and thumbnails.js so you have the code that creates the UI stuff in one file and the one that uploads the images in the other one. Would be less messy.

BoomerScratch commented 4 years ago

Use prettier for formatting code and making it clean. You can also use a GitHub action to automatically format code.

NoobTracker commented 4 years ago

yeah maybe add some nice semicolons.

NoobTracker commented 4 years ago

But currently it's not that bad I would say. You haven't seen my code yet.

NoobTracker commented 4 years ago

@BoomerScratch I can't tell you why, but somehow the code prettier creates is uglier then the original code imo.

jeffalo commented 3 years ago

Scratch Addons has released, and this is now available over there too!

NoobTracker commented 3 years ago

Yay! (but wasn't it already available before that release?)

jeffalo commented 3 years ago

Yay! (but wasn't it already available before that release?)

it was, but telling people to install an unfinished extension through their browser's developer options doesn't really sound that good