search

jeffbcross / offline-github

A prototype Github issues application with AngularJS 1.3 and Lovefield
3 stars 1 forks source link

Factory/Service for creating Github web hooks. #3

Closed davideast closed 3 years ago

davideast commented 9 years ago

This app will need to create web hooks on the fly. This requires an HTTP POST to the Github API. Rather than using ad-hoc $http.post() calls, this should be refactored into a service/factory.

jeffbcross commented 9 years ago

Good idea, what do you think for the name and API of the service?

jeffbcross commented 9 years ago

Oh, nm, I see you've started a branch https://github.com/jeffbcross/offline-github/commit/dc6457c0107b199def76ea0d5649a4615d866aff

davideast commented 9 years ago

I called the generic one, githubHookFactory. The one specific to the repo is called captainHook, because pirates are awesome.