search

jeffbski / bench-rest

bench-rest - benchmark REST (HTTP/HTTPS) API's. node.js client module for easy load testing / benchmarking REST API's using a simple structure/DSL can create REST flows with setup and teardown and returns (measured) metrics.
MIT License
303 stars 51 forks source link

add support for patch request #28

Closed ffoysal closed 8 years ago

ffoysal commented 8 years ago

many rest api developer needs PATCH request as well

ffoysal commented 8 years ago

@jeffbski Can I get your feedback on this.

jeffbski commented 8 years ago

@ffoysal this looks excellent! Thanks for submitting this PR.

Also if you would like, I'd be happy to add you as a contributor to this project, you did a great job with this PR.

jeffbski commented 8 years ago

@ffoysal I meant collaborator not contributor, so you can actually push changes too.

ffoysal commented 8 years ago

Sure @jeffbski I would love to be contributor/collaborator

jeffbski commented 8 years ago

Fantastic! I have added you now. It should be in your inbox. @ffoysal

ffoysal commented 8 years ago

I just did npm install bench-rest but looks like updated code is not there yet. not sure what needs to be done. Thanks for the help @jeffbski .

jeffbski commented 8 years ago

oops. I need to publish it to npm. will do that now and see about adding you as collaborator to that too.

jeffbski commented 8 years ago

ok, it is published now in npm v1.2.4 sorry for the confusion.

jeffbski commented 8 years ago

@ffoysal Do you have an account on npmjs.org? If so I can add you as a collaborator so you could push releases to npm as well.

ffoysal commented 8 years ago

Thanks for publishing @jeffbski my user name in npmjs is ffoysal

jeffbski commented 8 years ago

Alright, I've added you as a collaborator there too, so if you ever need to do a publish you can do so.

I've added some developer notes to the readme here https://github.com/jeffbski/bench-rest#developer-notes if you need to publish a new version. Feel free to ask me if any questions.

Thanks and have a great weekend!