jeffchan / truncate.js

fast, intelligent javascript text truncation
MIT License
98 stars 45 forks source link

Clarify usage of maxHeight option #19

Closed NoxHarmonium closed 8 years ago

NoxHarmonium commented 8 years ago

This may be a bit pedantic but I've used your plugin in a few of my projects and I always get confused about what unit to specify the max height in and have to look through the source code to work out that it should be in pixels. I thought it might help other people to add the pixel unit to the README file and to the source documentation to make it a little clearer.

Thanks for writing such a helpful plugin :smile:

jeffchan commented 8 years ago

:+1: