search

jeffctaylor / astro2013

A centralized place for my code this spring and summer
2 stars 0 forks source link

get_wavelength and units #8

Closed PBarmby closed 11 years ago

PBarmby commented 11 years ago

OK, I confess that I don't quite understand how the 'units' module in astropy works. But am I correct in thinking that this function is not making use of it? If we store the wavelength as a quantity with associated unit, then it's easy to convert later, yes?

sophiathl commented 11 years ago

Correct indeed - we have done the appropriate conversion - just didn't implement it yet - there are a few steps needed to get this 10^23 factor out within the astropy.units, as currently they include going from W/m^2/Hz to Jy, while we have erg/s/cm^2/Hz - thanks for noticing!

jeffctaylor commented 11 years ago

The get_wavelength() function has been removed, so I'm closing this issue as irrelevant.