search

jeffdaily / parasail-python

Python bindings for the parasail C library.
Other
90 stars 17 forks source link

libparasail.so missing in 1.1.15 #33

Closed kulesha closed 5 years ago

kulesha commented 5 years ago

ubuntu:$ find / -name 'parasail' 2>&1 | grep para /usr/local/lib/python2.7/dist-packages/parasail /usr/local/lib/python2.7/dist-packages/parasail/parasail.dll /usr/local/lib/python2.7/dist-packages/parasail-1.1.15.dist-info /usr/local/lib/python3.5/dist-packages/parasail /usr/local/lib/python3.5/dist-packages/parasail/parasail.dll /usr/local/lib/python3.5/dist-packages/parasail-1.1.15.dist-info ubuntu:$

installed version 1.1.14 and .so file is back

ubuntu:$ find / -name 'parasail' 2>&1 | grep para /usr/local/lib/python2.7/dist-packages/parasail /usr/local/lib/python2.7/dist-packages/parasail/libparasail.so /usr/local/lib/python2.7/dist-packages/parasail/parasail.dll /usr/local/lib/python2.7/dist-packages/parasail-1.1.14-py2.7.egg-info /usr/local/lib/python2.7/dist-packages/parasail-1.1.15.dist-info /usr/local/lib/python3.5/dist-packages/parasail /usr/local/lib/python3.5/dist-packages/parasail/parasail.dll /usr/local/lib/python3.5/dist-packages/parasail-1.1.15.dist-info ubuntu:$

jeffdaily commented 5 years ago

What exactly is your install command? pip? setup.py?

jeffdaily commented 5 years ago

Or I could just try to reproduce, because your error messages were absolutely correct had I looked more closely.

Fascinating. pip installing version 1.1.14 will run python setup.py bdist_wheel (which will download the parasail C library and build it), but pip installing version 1.1.15 will download a wheel with parasail.dll. Looking into this now.

kulesha commented 5 years ago

pip install parasail

thanks for looking into it so quickly !

On Thu, 14 Feb 2019 at 16:00, Jeff Daily notifications@github.com wrote:

Or I could just try to reproduce, because your error messages were absolutely correct had I looked more closely.

Fascinating. pip installing version 1.1.14 will run python setup.py bdist_wheel (which will download the parasail C library and build it), but pip installing version 1.1.15 will download a wheel with parasail.dll. Looking into this now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jeffdaily/parasail-python/issues/33#issuecomment-463682464, or mute the thread https://github.com/notifications/unsubscribe-auth/AEx6JW1wkB_lrS4paZhhqlccqIBreGQ9ks5vNYgTgaJpZM4a7i0b .

jeffdaily commented 5 years ago

One major difference is the set of packages hosted by pypi. For release 1.1.15, there appears parasail-1.1.15-py2.py3-none-any.whl (1.7 MB) Copy SHA256 hash SHA256 and this "any" wheel doesn't appear for any other releases. I manually removed it from pypi but it didn't work around the issue yet. I'm looking at how my distributions are packaged now.

jeffdaily commented 5 years ago

I verified that it is my appveyor packaging causing the rogue whl file. The reason v1.1.14 works is because my appveyor deploy failed.

jeffdaily commented 5 years ago

I think we're all good now. I just tagged v1.1.16 to kick off a new pypi version. Thank you for reporting and thanks for being a user.

kulesha commented 5 years ago

i can confirm that all is good again in 1.1.16 thanks for your work and incredibly quick fix !

daniil-lyakhov commented 3 years ago

Same behavior at parasail-1.2-py3.7.egg (1.2)

jeffdaily commented 3 years ago

@daniil-lyakhov please open a new ticket with more details.