jeffdaily / parasail-python

Python bindings for the parasail C library.
Other
90 stars 17 forks source link

use LD_LIBRARY_PATH to find libparasail #40

Closed fizwit closed 5 years ago

fizwit commented 5 years ago

on large Linux installations, we can assume that libparasail will be installed as a dependent library. The proper way to search for libraries is to look at LD_LIBRARY_PATH.

jeffdaily commented 5 years ago

It looks like this changes setup.py only. This change will prevent setup.py from downloading and building the latest C parasail release if find_library succeeds. At runtime, is the parasail module able to locate libparasail.so ok? I haven't ever tested this approach, having favored the bundled library approach.

fizwit commented 5 years ago

Yes, find_library succeeds at finding libparasail.so. You can specify a minimum version for parasail in the install docs.