search

jeffdepiazza / WODJournal

https://github.com/jeffdepiazza/WODJournal.git
0 stars 0 forks source link

proper listener setup of pr search and fix of fragmentactivity in workout search #10

Open jeffdepiazza opened 10 years ago

jeffdepiazza commented 10 years ago

Do we setup the listener properly upon activity creation and rotation? I'm not sure we do...and look and see if we even really need to be setting Search_started at all since we went from OnActivityCreated to OnCreate which will only get called once on activity creation, and not on rotation.

also, get rid of the fragment activity implementation in the workout search structure and go to strict activity and the mess that goes with it....model it after the personal record activity.

jeffdepiazza commented 9 years ago

I left this comment so long ago.....i looked at the activity implementatin of both the workout search and PR....they are structured the same and both have a display fragment...not sure what i was going for here. Also, for the listener...we may not even need this as the search is so fast that the screen rotation isn't even accomplished until the results are already in...i don't think we will loose the listener before the rotation... granted, as phones get faster, time will tell, but in addition to handling rotation faster, they will also execute the SQL query faster....