search

jeffdeville / sherlock_homes

0 stars 0 forks source link

Zillow property #5

Closed algodave closed 9 years ago

algodave commented 9 years ago

@jeffdeville

This covers Story 93706420 on Pivotal, except for mapping zillow data to our model.

Please run:

  $ export ZILLOW_KEY=<YOUR_KEY>

before running the PropertyFinder specs

jeffdeville commented 9 years ago

Let's rebase master to get the dotenv stuff in, and then put in the readme to copy the .env.sample file over as .env for testing purposes. At that point, it shouldn't matter what the default zillow id is, because the call is being hijacked by vcr anyway, right?

Then, just describe the situation in the readme.md in a section for how to contribute, or something like that.

jeffdeville commented 9 years ago

Also, please see if it's possible to add env variables to travis.ci (still fake ones), or if they have to be added via the interface.

algodave commented 9 years ago

@jeffdeville In order to keep git history clean perhaps it's better if I close this PR, remove the remote branch, rebase my local one and then share a new remote branch and open a new PR for it. What do you suggest?

jeffdeville commented 9 years ago

Can you rebase master into your branch, update the .env file, and force push?

jeffdeville commented 9 years ago

If not, do what you think is best, I have to be offline for a few hours. I'm sure you'll do fine. :-)

algodave commented 9 years ago

@jeffdeville Feel free to merge