jeffeb3 / sandify

web based user interface to create patterns that could be useful for robots that draw in sand with ball bearings.
MIT License
195 stars 35 forks source link

gcode import broken #246

Closed jeffeb3 closed 1 year ago

jeffeb3 commented 2 years ago

https://forum.v1engineering.com/t/sandify-update-v0-2-7/34684/7?u=jeffeb3

I think there might be an issue now with importing GCODE files in this new version of Sandify? I can import THR, but not GCODE or NC?

We need to look into this. I will try to check it out soon.

Specifically applies to 0.27

jeffeb3 commented 2 years ago

Confirmed. Down deep inside gcode-toolpath there is an undefined variable being used. I can't see a difference between what we are doing and the example. I also don't see how it changed. My guess is something else updated and broke a dependency on gcode-toolpath. We should probably open an issue there to see if they can help. Or else dig into the source to see what could have changed.

I would like to get this fixed as soon as we do another minor update to remove the notice. But I can't fix it very soon.

I tested with firefox.

screenshot-2022-10-14-1665778878