jefferis / nabor

R package wrapping libnabo: fast K Nearest Neighbor search for low dimensions
https://github.com/ethz-asl/libnabo
Other
22 stars 0 forks source link

remove register keyword from libnabo #9

Closed jefferis closed 6 years ago

jefferis commented 6 years ago

BDR quoth

The C keyword 'register' was deprecated in C++11. Now it has been removed in C++17, clang trunk (to be released as clang 6.0.0 in a couple of months) has started warning on its use by default. Packages BayesXsrc DatABEL FCNN4R FNN FRESA.CAD KODAMA Matching NPBayesImpute OjaNP RANN RSNNS RSSL SnakeCharmR TAQMNGR TransferEntropy bipartite cems distances divest dpmixsim logconPH ltsk mixcat mombf msr mvPot nabor nonlinearTseries phreeqc reticulate rstpm2 smoothSurv invoke this warning. Please remove C++ uses of 'register' at the next update.

Several months have now gone by and R-devel now defaults to C++11 if available. Packages

FCNN4R FNN KODAMA NPBayesImpute OjaNP RANN RSNNS RSSL SnakeCharmR TransferEntropy bipartite distances dpmixsim ltsk mixcat msr nabor nonlinearTseries phreeqc smoothSurv

have not yet been updated to remove 'register'. Please do so before Aug 10 to safely retain the package on CRAN.

(If for some reason you wish to retain 'register' you could declare your code to be C++98: see 'Writing R Extensions'.)