search

jeffersonlicet / react-motion-layout

🦸 Beautiful immersive React hero animations.
https://motion-layout.azurewebsites.net/
MIT License
592 stars 24 forks source link

Compatibility with react-router-dom v6 #24

Open Moshyfawn opened 3 years ago

Moshyfawn commented 3 years ago

Describe the bug A clear and concise description of what the bug is. App build fails with No matching export in "node_modules/react-router-dom/index.js" for import "useHistory" when using version 6.0.0-beta.0 of react-router-dom.

To Reproduce Steps to reproduce the behavior:

  1. Install history & react-router-dom@next packages
  2. Install react-motion-layout package
  3. Use the Motion Layout Provider as per http://motion-layout.com/docs/animating#1-use-the-motion-layout-provider
  4. Try running the dev server (yarn dev, npm start etc.)
  5. See error

Expected behavior Dev server runs without errors.

Screenshots build error in the terminal example

Additional context The issue is kind of related to #13. I saw this reply, which states that there's going to be a new version of the package. Idk if it's going to be a router-agnostic solution or a Next.js router compatibility update. react-router-dom package had it's pretty stable beta release for quite a while now. It might be good to adopt some router-agnostic solution in the future

Nefonfo commented 2 years ago

Now react router V6 it's stable, any plan of migrate to V6 😅?

Moshyfawn commented 2 years ago

I don't think this lib is maintained anymore, tbh