Bug: Interface-based Abstractions Throws Missing FieldOrder Attribute

jefffhaynes / BinarySerializer

A declarative serialization framework for controlling formatting of data at the byte and bit level using field bindings, converters, and code.

MIT License

289 stars 62 forks source link

Bug: Interface-based Abstractions Throws Missing FieldOrder Attribute #140

Closed Texnomic closed 4 years ago

Texnomic commented 5 years ago

When using Interface-based Abstractions, The following case works only if Interface IDomain members are marked with FieldOrder Attributes. Otherwise ThrowIfUnordered() throws InvalidOperationException because it checked Interface IDomain members not type Domain members.

public interface IDomain
{
        List<ILabel> Labels { get; }
        string Name { get; }
}

public class Domain : IBinarySerializable, IDomain
{
        [Ignore]
        public List<ILabel> Labels { get; }

        [Ignore]
        public string Name => ToString();

        public void Serialize(Stream Stream, Endianness Endianness, BinarySerializationContext Context)
        {
           //Code
        }

        public void Deserialize(Stream Stream, Endianness Endianness, BinarySerializationContext Context)
        {
            //Code
        }

}

public class Question : IQuestion
{
        [FieldOrder(0)]
        [SubtypeDefault(typeof(Domain))] //Check Issue #139 
        public IDomain Domain { get; set; }
}