jeffhain
commented
6 years ago Hello, and thank you for proposing upgrades to Jafama.
About working with Java 8/9:
Jafama should already work properly (jar usable, and source compilable) with these, as it does with Java 5 to 7, since it only uses very basic non-deprecated language features (static methods, primitive types, etc.).
About adding support to IntelliJ/Gradle/Travis:
I don't want to tie Jafama with any third-party tooling, it's aimed at containing only the "pure" sources, plus eventually some code to generate the jar in a reproductible and self-reliable way using JDK internal tools. Even if there was only one IDE and build tool in the world, I would not do it, and there are hundreds. I use Eclipse myself, and didn't add .project or .classpath files. Just forking Jafama and adding the files for your tooling of choice should be the right way to go.
About code reformating:
Your changes correspond to my current formatting style (spaces in for loops definitions, etc.), so I might piggyback this along with other (more featuresque) modifications for another version of Jafama (maybe for Java 9, as a module? I have no plan yet).
About creating a CHANGELOG.txt file:
That's a good idea, the README should just be an introduction to latest version. As for reformating, I could do it for a new version.
About using Markdown for README:
I'm a simplicity fanatic, so while I might (or might not!) use .md format to help make a large file more readable, I don't think I'll use it for something as simple as a README ought to be. Unless maybe I'm the only one left in the world using .txt, but even then, I think I would stick to it.
So as a result of all this I won't pull your changes into Jafama. Also currently I'm working on some other and big thing, and I feel like a context-switch would require me as much energy as for a diplodocus to turn back. Hoping that doesn't disappoint you too much!
-Jeff
ghost
This pull request updates jafama to work with the latest Java (8/9) and allows building and use with grade. This also adds a template for travis ci builds.