jeffharrell / minicart

The minicart is a great way to improve your PayPal shopping cart integration.
MIT License
500 stars 209 forks source link

Cannot Close the shopping Cart in Google Chrome! #224

Open mike001 opened 10 years ago

mike001 commented 10 years ago

I have tried your test site: http://minicartjs.com/#customization in Google Chrome and when I try to close the shopping cart I experience the same issue as on my test site... No close action?

Do you have a fix for this issue?

jeffharrell commented 10 years ago

I'm unable to reproduce this on minicartjs.com. Clicking both the "x" and outside of the cart cause it to close in Chrome 34. Can you provide more details?

mike001 commented 10 years ago

On your test site, and on my site that I am building I am experiencing an issue when closing the shopping cart, and the on click action of the add to cart button. This issue does not seem to present itself on IE, Mozilla, or on the IPhone. I do see this issue on IPad, and and within Google Chrome. Google Chrome Version 34.0.187.116 m (and states that it is up to date) Iphone and Ipad both have the same IOS and is the latest revision.

legenderrys commented 10 years ago

@mike001 Im having the same issues using the same chrome version. delete product button from cart, close cart button and clicking outside modal window does not work

@jeffharrell on my http://shop.gullahcelebration.com using an older version that works in the latest chrome browser. minicartjs.com has issues in latest chrome.

legenderrys commented 10 years ago

@mike001 @jeffharrell minicartjs now works in Chrome version 35!

salberty commented 10 years ago

I also had the issue where Firefox and IE worked fine, but not Chrome.

The issue turned out to be how I named the JS file. I was running a tweaked version of the .min.js file, but named it "js-minicart.js" (without the .min). This worked fine in Firefox and IE, but when I tested in Chrome it was as if it didn't read the file at all and just loaded the old paypal cart in a new browser tab.

I then renamed the file to js-minicart.min.js (added back the .min) and now Chrome reads the file and it functions perfectly.

iangeek commented 10 years ago

Same issue here on the minicartjs.com site... Delete, close or clicking outside the modal does nothing. All other functions work fine.

Running Chrome 35 on Windows. Also same bug occurs on Canary (Chrome 38)

jeffharrell commented 10 years ago

It shouldn't matter, but @mike001 are you on Windows as well? I'm on a Mac so that possibly could account for the difference.

mike001 commented 10 years ago

Yes I am on Windows & also trying from MAC OS on IPhone, and IPad

jeffharrell commented 10 years ago

Good to know. I'll investigate in a bit once I have my VM set up properly.

jeffharrell commented 10 years ago

I'm still unable to reproduce this on minicartjs.com with Chrome 36 in Windows 7 and 8. If anyone who can reproduce can debug that would be great.

tomcastleman commented 10 years ago

Hi Jeff,

I am also experiencing this bug on Chrome 36.0.1985.143 m on Windows 8.1:

You can see the cart and problem here: http://www.railbookers.com/gift-vouchers?redirectdisable

It worked fine when this was implemented a few months ago.

Edit: Console shows no errors, and removing the jquery.Cycle from the DOM does not fix the issue (I thought it may be an event / z-index issue).

legenderrys commented 10 years ago

@jeffharrell I could do some debugging if you could provide where the close events are handled in the source code, I may be able to help. Im learning javascript and have some downtime.

Assuming i should start here https://github.com/jeffharrell/minicart/blob/master/dist/minicart.js#L1824

https://github.com/jeffharrell/minicart/blob/master/dist/minicart.js#L2938

jeffharrell commented 10 years ago

@hyperking that would be awesome if you could help!

Yes, those are the two areas you should be interested in. Specifically, the proxy click function the latter one uses (https://github.com/jeffharrell/minicart/blob/master/dist/minicart.js#L2930-L2960) is probably not getting executed or if it is then the classname may not be getting set properly.

legenderrys commented 10 years ago

@jeffharrell @tomcastleman Latest version of Chrome 37.0.2062.122 corrects this issue on windows 7 & 8 from what i have tested. Will look into Canary later.

legenderrys commented 10 years ago

corrections latest version of Chrome Version 37.0.2062.124 on windows 7 machine has issues now. Was really hoping this was a browser issue.

murraymint commented 9 years ago

I'm experiencing this issue in Chrome Version 40.0.2214.93 m Works fine on Firefox and IE, but doesn't give me the ability to close the minicart or delete items. I assume it's an ongoing issue from the length of this thread?

ibelong2u commented 9 years ago

I'm experiencing this issue too: the buttons (to close the cart, and to remove the product) do not work in Chrome, on a touch-screen display.

On my touch-screen laptop, the buttons have 2 event listeners: 'keyup' and 'touchstart' in chrome - the buttons respond to touch, but not click. However, when I disable the touch functionality and restart the browser, the buttons have 3 event listeners: 'click', 'error', and 'keyup' - and they respond to click normally.

philmosby commented 7 years ago

As ibelong2u discovered over a year ago, this is an issue that only seems to occur on laptops that have both a mouse / touch pad AND a touch screen.

Exactly as described, in this scenario the Close "X" button, Remove from cart, and close via clicking outside of the cart actions are broken when clicking via the Mouse / Touch Pad. Touching the screen DOES work.

I have to have this working tonight so I'm going to try to fix the problem, I'll submit the solution if I find an adequate one.