search

jeffheaton / encog-java-core

http://www.heatonresearch.com/encog
Other
743 stars 268 forks source link

Persist fix - fixes activation function and limited network persistence #121

Closed RobertCoop closed 10 years ago

RobertCoop commented 11 years ago

Recreated pull request, now correctly located in its own branch

jeffheaton commented 11 years ago

Thanks, I can see where the full path of the activation function could be useful, but if I pull it in like that it will break compatibility with C# and also existing EG files. I will look at a way to add the full path for activation functions outside of the standard Encog activation functions. I can't take it exactly as you have it because that would break the ability for Java/C# based EG files to be interchangeable.

RobertCoop commented 11 years ago

Makes sense. I'm not a C# guy, but I would think you could change the format for that to have a 'name' column, 'Java class name' column, a 'C# name' column, and then the parameter values.

Bobby Coop, PhD Student Machine Intelligence Lab http://mil.engr.utk.edu

University of Tennessee Dept. of Electrical Engineering & Computer Science 414 Ferris Hall 1508 Middle Drive Knoxville, TN 37966-2100

On Tue, Oct 23, 2012 at 9:58 PM, Jeff Heaton notifications@github.comwrote:

Thanks, I can see where the full path of the activation function could be useful, but if I pull it in like that it will break compatibility with C# and also existing EG files. I will look at a way to add the full path for activation functions outside of the standard Encog activation functions. I can't take it exactly as you have it because that would break the ability for Java/C# based EG files to be interchangeable.

— Reply to this email directly or view it on GitHubhttps://github.com/encog/encog-java-core/pull/121#issuecomment-9725209.

jeffheaton commented 10 years ago

Finally merged this. Thankyou for the change. I made a few small changes to keep C# compatibility between files.