jeffheaton / encog-java-core

http://www.heatonresearch.com/encog
Other
744 stars 268 forks source link

BasicNetwork.reset() vs basicNetwork.reset(int) #181

Closed pijusn closed 9 years ago

pijusn commented 9 years ago

I have noticed BasicNetwork has two reset methods:

public void reset() {
    getRandomizer().randomize(this);
}

And one with a seed variable:

public void reset(final int seed) {
    Randomizer randomizer = getRandomizer();
    randomizer.randomize(this);
}

However, seed variable is not used and they do the same thing. It does not seem right. It seems like the second method is supposed to initialise randomiser with given weights.

jeffheaton commented 9 years ago

Thanks, yes I agree that is incorrect.

jeffheaton commented 9 years ago

Just checked in a fix for this. Thanks for the report.