jeffheaton / encog-java-core

http://www.heatonresearch.com/encog
Other
742 stars 268 forks source link

NormalizationHelper is not serializable #194

Closed andrewthomas28 closed 9 years ago

andrewthomas28 commented 9 years ago

The class NormalizationHelper is marked and documented to be serializable. However, it is not. An attempt to serialize a NormalizationHelper results in a NotSerializableException.

From the code:

public class NormalizationHelper implements Serializable ...

From the "Encog Quick Start Guide," v3.3, at https://s3.amazonaws.com/heatonresearch-books/free/encog-3_3-quickstart.pdf:

"You can also serialize the normalization helper."

The problem is caused at least by the following:

andrewthomas28 commented 9 years ago

Addressed in pull request https://github.com/encog/encog-java-core/pull/195 .

jeffheaton commented 9 years ago

Thanks for the fix and unit test.