jeffheaton / encog-java-core

http://www.heatonresearch.com/encog
Other
744 stars 268 forks source link

encog-java-core #194: NormalizationHelper is not serializable #195

Closed andrewthomas28 closed 9 years ago

andrewthomas28 commented 9 years ago

This change addresses the issue at https://github.com/encog/encog-java-core/issues/194 : NormalizationHelper is not serializable.

This change includes making the following Serializable:

This change adds a new unit test to verify serializability of NormalizationHelper: org.encog.ml.data.versatile.TestNormalizationHelper.

To support the unit test, equals() methods were added to the following:

Also, this pull request includes a trivial fix for encog-java-core #192: ColumnDefinition: default index should be -1. More detail: https://github.com/encog/encog-java-core/issues/192

All unit tests are green after these changes. A test build succeeded.

janisz commented 9 years ago

It looks like you have wrong end of line character.

andrewthomas28 commented 9 years ago

@janisz - Sorry, hadn't noticed. I think I've addressed that. Please let me know if there's still a problem.

jeffheaton commented 9 years ago

Thank you this looks good.