jeffheaton / encog-java-core

http://www.heatonresearch.com/encog
Other
742 stars 268 forks source link

Fix global best position update in PSO #227

Closed Turakar closed 8 years ago

Turakar commented 8 years ago

The udateGlobalBestPosition() method in NeuralPSO fails if the current best particle finds a better position, because the old method was comparing the new error with the new error in the array, which are equal. Now, it is comparing against the old error saved in the BasicTraining class.

If you're going to merge this, I would be interested to know about in which version this fix will be published, as I'm using this code in my current project build with gradle.

jeffheaton commented 8 years ago

Thank you, I will take a look at this soon. I will make sure to include this in the next Encog version, which is a bit overdue. I hope to have a gradle-pushed version of Encog by the end of July, at the latest.

jeffheaton commented 8 years ago

Thank you very much for the bug fix. This has been merged and will be a part of Encog 3.4. My plan is for this to be released in a few weeks.