search

jeffheaton / encog-java-core

http://www.heatonresearch.com/encog
Other
742 stars 268 forks source link

Ml method genetic algorithm finish training fix #234

Closed michaellavelle closed 7 years ago

michaellavelle commented 7 years ago

This PR contains 2 fixes:

1) Removing use of diamond operator to ensure compatibility with Java 1.6 - as specified by the pom.xml

2) Ensuring that the finishTraining() method of MLMethodGeneticAlgorithm also calls finishTraining() on it's internal helper class. Not calling finishTraining() on the helper class can result in un-shutdown Task Executors and appears to cause a memory leak

jeffheaton commented 7 years ago

Thank you for these changes.

jeffheaton commented 7 years ago

Thank you for these changes, they have been merged with the project.