search

jeffheaton / encog-java-core

http://www.heatonresearch.com/encog
Other
742 stars 268 forks source link

modify the if statment which check if center[i] at the boundary of th… #239

Closed xietiantian closed 6 years ago

xietiantian commented 7 years ago

modify the if statment which check if center[i] at the boundary of the neuron mesh the boundary of the neuron mesh is minPosition and maxPosition, two parameters of "setRBFCentersAndWidthsEqualSpacing" method, right? They may have various values, though typically 0 and 1. For example in the constructor "public RBFNetwork(final int inputCount, final int hiddenCount, final int outputCount, final RBFEnum t)", setRBFCentersAndWidthsEqualSpacing method is called with patameters minPosition = -1 and maxPosition = 1 so, I think the boundary check should be like this: if ((centers[i][z] == minPosition) || (centers[i][z] == maxPosition))

jeffheaton commented 7 years ago

Thank you I will look at this soon for the next release of Encog.

jeffheaton commented 6 years ago

Agree with this change, thanks! Will add to C# too.