jeffhussmann / knock-knock

toolkit for analyzing genome editing experiments
GNU General Public License v3.0
20 stars 9 forks source link

build-targets step error #5

Closed shp9n closed 1 year ago

shp9n commented 1 year ago

I hope to use knock-knock to analyze diverse insertion events by sgRNA/Cas9 and homology donor, but got the below message at the build-targets step. I wonder if the current version of the script is compatible with the example files from 3 years ago or if I missed something from setup. Any guidance would be greatly appreciated. Thank you very much for your time!

knock-knock build-targets PROJECT_DIR

Traceback (most recent call last): File "/opt/rice/anaconda3/bin/knock-knock", line 236, in args.func(args) File "/opt/rice/anaconda3/bin/knock-knock", line 124, in build_targets defer_HA_identification=args.defer_HA_identification, File "/opt/rice/anaconda3/lib/python3.7/site-packages/knock_knock/build_targets.py", line 1142, in build_target_infos_from_csv for pegRNA_name, pegRNA_components in info['pegRNAs']: TypeError: 'NoneType' object is not iterable

hukai916 commented 1 year ago

You are right, I am also testing out knock-knock, the example file seems missing pegRNAs column that is required by the latest version of knock-knock. Version 0.3.7 does not seem to have the same issue.

shp9n commented 1 year ago

Thank you!

hukai916 commented 1 year ago

Hi @shp9n ,

Also checkout: https://github.com/jeffhussmann/knock-knock/issues/12

shp9n commented 1 year ago

Hi @hukai916, I checked #12 on v0.4.1. Were you able to run the example file using Version 0.3.7 using the donor sequence? Thanks!

hukai916 commented 1 year ago

@shp9n , nope, knock-knock can not properly read in the donor sequence in my test. It could be due to outdated example column name, but I am not sure. When I have time, I can dig into it further.

jeffhussmann commented 1 year ago

Hi @shp9n -

Thanks for you interest in knock-knock!

The issues you have run in to should be fixed by commit https://github.com/jeffhussmann/knock-knock/commit/1871c414a7090f2d3f0ee52648377f1da4b39c5e. See also discussion in https://github.com/jeffhussmann/knock-knock/issues/12.