search

jeffijoe / awilix-express

Awilix helpers/middleware for Express
MIT License
118 stars 7 forks source link

Adding descriptive error for non existing method being invoked on con… #10

Closed jhoscar1 closed 6 years ago

jhoscar1 commented 6 years ago

…troller.

Fixes issue #9

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 726792cb4e49320b606dabad56c8cf71bbbbdb99 on jhoscar1:invoker-descriptive-error into 67bbfe3d998ae90110cbc0ecdaa2f73c42a2ccbf on talyssonoc:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 25dddbc2a77c667ef04fca5892f2e600a38e04b8 on jhoscar1:invoker-descriptive-error into 67bbfe3d998ae90110cbc0ecdaa2f73c42a2ccbf on talyssonoc:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 25dddbc2a77c667ef04fca5892f2e600a38e04b8 on jhoscar1:invoker-descriptive-error into 67bbfe3d998ae90110cbc0ecdaa2f73c42a2ccbf on talyssonoc:master.

talyssonoc commented 6 years ago

Hello @jhoscar1! Thanks for the contribution 😄

The file you changed is the one that is generated automatically by TypeScript, could you change the original TS one instead (here https://github.com/talyssonoc/awilix-express/blob/master/src/invokers.ts#L93) and then npm run build so the file at lib folder is updated automatically?

jhoscar1 commented 6 years ago

@talyssonoc Excited and glad to contribute! Apologies for that mistake, should be good now! 😄