search

jeffijoe / awilix-express

Awilix helpers/middleware for Express
MIT License
118 stars 7 forks source link

Update controller.ts #51

Closed PopescuIon closed 7 months ago

jeffijoe commented 10 months ago

Hi @PopescuIon, could you provide some context for the requested change?

PopescuIon commented 10 months ago

Because when I try to use the awilix-express library I get these errors Namespace '"/node_modules/glob/dist/commonjs/index"' has no exported member 'IOptions'. I've been reading up on glob modules and noticed that it returns the GlobOptions interface and not IOptions I made these modifications locally and it works ok but I have problems when I publish to the server

În mar., 9 ian. 2024 la 11:40, Jeff Hansen @.***> a scris:

Hi @PopescuIon https://github.com/PopescuIon, could you provide some context for the requested change?

— Reply to this email directly, view it on GitHub https://github.com/jeffijoe/awilix-express/pull/51#issuecomment-1882725420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGKDWJEGOOP2OTMQWJXGCWLYNUGBJAVCNFSM6AAAAABBSZC222VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSG4ZDKNBSGA . You are receiving this because you were mentioned.Message ID: @.***>

jeffijoe commented 10 months ago

That is weird, I've updated all dependencies locally and it's still IOptions for me.

jeffijoe commented 10 months ago

I released a new version, please check and see if that is still causing issues. If not, please rebase this PR so it runs the CI, I just migrated to GHA.