fix: Fix sourcemaps content

jeffijoe / mobx-task

Makes async function state management in MobX fun.

MIT License

238 stars 6 forks source link

fix: Fix sourcemaps content #25

Closed InvictusMB closed 4 years ago

InvictusMB commented 4 years ago

Source TS files are not bundled with the package while the generated sourcemaps don't contain sourcesContent. Either one has to be fixed in order for sourcemaps to be valid. This fix tells TS compiler to emit sourcesContent similar to mobx-react-lite .

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 4aac0abb4bdbb0e1d9e7d42aba0deff832fbabd1 on InvictusMB:master into 0e4e7df1305feb9c715fc5af8fb204889f22b1b4 on jeffijoe:master.

jeffijoe commented 4 years ago

Thank you for this!

jeffijoe commented 4 years ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

InvictusMB commented 1 year ago

@jeffijoe Looks like the source maps issue has reappeared in v3.0.0

jeffijoe commented 1 year ago

@InvictusMB that's odd, I don't think anything was changed regarding how that's handled

jeffijoe commented 1 year ago

Oh weird, appears that line is gone from tsconfig 🤔

jeffijoe commented 1 year ago

@InvictusMB I'll open a PR to re-add this. I also need to migrate to GitHub Actions so it might be a minute.

jeffijoe commented 1 year ago

@InvictusMB this has been fixed in v3.0.1, thanks for bringing it up!