search

jeffijoe / typesync

Install missing TypeScript typings for dependencies in your package.json.
MIT License
1.53k stars 22 forks source link

Allow regexes or minimatch-like sytax to work in ignores #124

Open AndreaPontrandolfo opened 1 month ago

AndreaPontrandolfo commented 1 month ago

It would be nice if the syntax for the various ignores options could be widened with regexes or minimatch-like syntax.

jeffijoe commented 1 month ago

Regex and minimatch are CVE nightmares, if we do this it would be basic starts-with foo* and ends with *foo.

lishaduck commented 1 month ago

Does typesync support JS config files? Couldn't you just use native regexes? If there's an issue it'd be your (configurer's) own fault and it doesn't pull in a library for matching.

jeffijoe commented 1 month ago

It does, but it feels weird to force users to use JS config files to enable a particular feature.

lishaduck commented 3 weeks ago

Oh, forgot this. Added globs for ignored projects in #126. Is it ok if it's inconsistent?

EDIT: We already depend on minimatch anyway. tinyglobby doesn't though, if you'd prefer a PR in that direction.

jeffijoe commented 3 weeks ago

We already depend on glob which as you said depends on `minimatch. #126 is fine.