search

jeffijoe / typesync

Install missing TypeScript typings for dependencies in your package.json.
MIT License
1.53k stars 22 forks source link

Fix additon of extraneous fields #132

Closed lishaduck closed 5 days ago

lishaduck commented 2 weeks ago

Haven't tracked down the source of the bug yet.

coveralls commented 2 weeks ago

Coverage Status

coverage: 100.0%. remained the same when pulling b3e3072b9b8796dbdc0151e6a80ed08257084b7b on lishaduck:extraneous-fields into fee1f00c98749f8002c29c8ef7de57b310414251 on jeffijoe:master.

lishaduck commented 2 weeks ago

I gave up writing regression tests, but otherwise I'm happy with this.

lishaduck commented 2 weeks ago

Also, if developing on node>=18, you can apply a patch and build with tsdown, which is much faster (and it has a nice watch mode, which tsc maybe(?) has?):

Patch

```diff ts diff --git a/bin/typesync b/bin/typesync index 95dbe55..e28f57c 100755 --- a/bin/typesync +++ b/bin/typesync @@ -1,4 +1,2 @@ #!/usr/bin/env node -const { startCli } = require('../lib/cli') - -startCli() +import('../dist/cli.mjs').then(({ startCli }) => startCli()) ```

Build command: pnpm dlx tsdown --watch src/cli.ts (npx tsdown --watch src/cli.ts for npm)

jeffijoe commented 2 weeks ago

I’m out on vacation, I’ll check on these when I get back. 👍

jeffijoe commented 5 days ago

Thanks, released as 0.13.4!