fix(cli): --dry=fail should also fail when either added or removed typings

jeffijoe / typesync

Install missing TypeScript typings for dependencies in your package.json.

MIT License

1.53k stars 22 forks source link

fix(cli): --dry=fail should also fail when either added or removed typings #87

Closed chelkyl closed 2 years ago

chelkyl commented 2 years ago

Now correctly checks even if only added or only removed typings. Sorry for the bad logic in the original PR.

coveralls commented 2 years ago

Coverage remained the same at 100.0% when pulling 0d5589d882fca46e1f6ee84657ebbe5875ca1805 on chelkyl:fix-dry-run-fail into 3b445b34b75ad92c384c47fc048a68f18a06076c on jeffijoe:master.

jeffijoe commented 2 years ago

The CI is failing due to Node 18 being the new stable, but not sure why?

chelkyl commented 2 years ago

Looks like the build config needs to be updated to choose a distribution newer than xenial. See: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442

From the NodeJS repo BUILDING.md, Linux binaries are now built on RHEL 8 and the footnote says:

Binaries produced on these systems are compatible with glibc >= 2.28 and libstdc++ >= 6.0.25 (GLIBCXX_3.4.25). These are available on distributions natively supporting GCC 8.1 or higher, such as Debian 10, RHEL 8 and Ubuntu 20.04.

jeffijoe commented 2 years ago

I see, thanks! Would you mind updating the travis config in this PR? 😄

chelkyl commented 2 years ago

No problem! Updated to focal and it is passing all but 14. The build failure seems to be a network fluke or something because the error is read ECONNRESET.

jeffijoe commented 2 years ago

Nice, thanks! I’ll merge and release tomorrow, appreciate it!