jeffkl / MSBuildProjectCreator

A fluent API for creating MSBuild projects for use by unit tests
MIT License
47 stars 4 forks source link

Enable transitive pins and bump System.Text.Json #306

Closed MattKotsenas closed 1 month ago

MattKotsenas commented 1 month ago

Fix broken build due to NU1903.

To do so I:

  1. Enabled transitive pinning
  2. Bumped System.Text.Json to 6.0.10 for .NET 6.0
  3. Bumped System.Text.Json to 8.0.5 for all other TFMs

This mirrors the existing logic, but it isn't entirely clear to me why it was this way to begin with.

Comparing packages before and after, the version is bumped as expected (and no other package dependencies change) except the .NET 6.0 TFM now has a dependency on System.Text.Json.

MattKotsenas commented 1 month ago

Here's the side-by-side (Old vs. New) in NuGet Package Explorer for this change

image

You know this area much better than me, so feel free to do what you please. Just helping out where I can since I already have the project open :)

MattKotsenas commented 1 month ago

Same as #305, so pick which one you like better and close the other one ;)

jeffkl commented 1 month ago

I'm not ready for transitive pinning just yet 😄