jeffknupp / review

Code for project reviews
38 stars 17 forks source link

Use something other then sqlite #20

Open voidfiles opened 10 years ago

voidfiles commented 10 years ago

It's great for development, but when you actually deploy probably won't work, right?

jeffknupp commented 10 years ago

Would work fine while the database is small and uncomplicated. I actually run bull, my digital sales app for selling my book, with sqlite as it simplifies things for small databases.

That being said, if you want to change the DB engine, you're welcome to send a pull request :)

voidfiles commented 10 years ago

Out of curiosity how is this app deployed?

On Tue, Mar 11, 2014 at 11:14 AM, Jeff Knupp notifications@github.comwrote:

Would work fine while the database is small and uncomplicated. I actually run bull, my digital sales app for selling my book, with sqlite as it simplifies things for small databases.

That being said, if you want to change the DB engine, you're welcome to send a pull request :)

Reply to this email directly or view it on GitHubhttps://github.com/jeffknupp/review/issues/20#issuecomment-37330074 .

jeffknupp commented 10 years ago

The contents are copied to a certain directory (/srv/www/bull) and the app is run via uWSGI controlled by supervisor. So the database ends up being a file in the top level of the directory hierarchy.

voidfiles commented 10 years ago

Are you running multiple workers? I guess I am wondering how sqlite3 does when you start to increase concurrency.

On Tue, Mar 11, 2014 at 11:30 AM, Jeff Knupp notifications@github.comwrote:

The contents are copied to a certain directory (/srv/www/bull) and the app is run via uWSGI controlled by supervisor. So the database ends up being a file in the top level of the directory hierarchy.

Reply to this email directly or view it on GitHubhttps://github.com/jeffknupp/review/issues/20#issuecomment-37331996 .

jeffknupp commented 10 years ago

SQLite can certainly handle the level of concurrency I require. I just run 3 workers, but SQLite is one of the most tested open source projects around, so I wouldn't be surprised if it can handle as many threads as your process can create.

On Tue, Mar 11, 2014 at 2:33 PM, Alex Kessinger notifications@github.comwrote:

Are you running multiple workers? I guess I am wondering how sqlite3 does when you start to increase concurrency.

On Tue, Mar 11, 2014 at 11:30 AM, Jeff Knupp <notifications@github.com

wrote:

The contents are copied to a certain directory (/srv/www/bull) and the app is run via uWSGI controlled by supervisor. So the database ends up being a file in the top level of the directory hierarchy.

Reply to this email directly or view it on GitHub< https://github.com/jeffknupp/review/issues/20#issuecomment-37331996>

.

Reply to this email directly or view it on GitHubhttps://github.com/jeffknupp/review/issues/20#issuecomment-37332433 .