search

jeffkowalski / geeknote

Console client for Evernote.
GNU General Public License v3.0
393 stars 50 forks source link

make copy&paste work when entering token #96

Closed dindom999 closed 6 years ago

dindom999 commented 6 years ago

Hi jeffkowalski, I am using arch+i3, pasted from clipboard fail, so I change it. I will test it later in ubuntu.

jeffkowalski commented 6 years ago

@dindom999 - did you re-test? What did you find?

dindom999 commented 6 years ago

hi @jeffkowalski , I test it again. you are right ! getpass accepts pastes. I don't konw why it fail before, maybe there is a space or "\b" at the end of word when I copied, and I can't see it because getpasss don't show anything. So, I suggest to add a "strip()" like getpass.getpass.strip()

jeffkowalski commented 6 years ago

@dindom999, the strip you recommend is a reasonable improvement. Unfortunately, this pull request is now complicated with several independent changes, none of which contain the strip. (It's a good practice to submit only one kind of change per pull request. Here you have three. This time, it's OK, but in the future please separate them.) Please remove the raw_input and replace with strip after getpass. Thanks.

dindom999 commented 6 years ago

hi @jeffkowalski , I have changed back to getpass. sorry to make things mass.

jeffkowalski commented 6 years ago

Thank you, @dindom999 I've merged into 2.0.15