search

jeffkreeftmeijer / vim-dim

Dim (/dɪm/; a contraction of Default IMproved) is a clone of Vim’s default colorscheme, with some improvements.
https://jeffkreeftmeijer.com/vim-16-color
248 stars 30 forks source link

Invisible comments inside popup menus #10

Open veselyn opened 1 year ago

veselyn commented 1 year ago

The PMenu highlight group has the same background color as the foreground color of Comment, therefore, comments are "invisible" inside popup menus. This is the case for both of the background options (light or dark).

Would it make sense to swap the Comment highlights between light and dark mode here: https://github.com/jeffkreeftmeijer/vim-dim/blob/main/colors/dim.vim#L26-L54?

Light mode

image

Dark mode

image

Actual content inside the popup menu

image
jeffkreeftmeijer commented 1 year ago

Could you show how that would look? I think I’d rather change the background colors of the pmenus than changing the comment colors, but I could be wrong.

veselyn commented 1 year ago

This is how the comments look like in a popup menu with the colors swapped (with background set to dark):

image

However, outside of the popup menus, the comments blend in with other highlights:

image image

Perhaps it makes more sense to swap the colors of the pmenus instead so the comments can remain with lower contrast.

This is how it looks like for me with them swapped (top picture is with background set to dark): image image