search

jeffkreeftmeijer / vim-dim

Dim (/dɪm/; a contraction of Default IMproved) is a clone of Vim’s default colorscheme, with some improvements.
https://jeffkreeftmeijer.com/vim-16-color
250 stars 32 forks source link

StatusLine highlights are low-contrast #7

Open pbnj opened 3 years ago

pbnj commented 3 years ago

Thank you for this theme. I have been maintaining a similar "default-improved" theme, but recently switched to this one, which has been great so far.

One minor nuisance is the current highlight for StatusLine, which is White (ctermfg=15) on Gray (ctermbg=8). This results in hard-to-read, low-contrast colors between the statusline text and the background color.

The default colorscheme sets this to black text on white background, which is better for contrast, but also feels like it would even be a better fit for grim (the monotone theme) better than White on Gray.

Any chance you'd be open to reconsider this and perhaps change StatusLine highlight to Black on White for dim and/or grim?

jeffkreeftmeijer commented 3 years ago

Hey @pbnj!

Thanks for raising this issue. I’m trying to keep the colors similar between Dim and Grim, outside of the syntax highlighting, so I’d prefer to keep the colors of the StatusLine the same between the two (although, that’s not set in stone and we can always decide to push a version with that rule dropped).

The dimmed status lines and line numbers are part of an idea to have them fade out of view to focus on the code, and the current coloring is indeed low contrast, but it works for me in my current theme and with the default status line setup. I know others have more elaborate setups, so I’d love to see how it looks for you.

Could you post a screenshot to take a look at how it looks in your setup?