Re wrote the plugin in order to have more functionality and be more efficient

greduan commented 11 years ago

The summary of what I did is below. I'm afraid having multiple pull requests at the same time is not possible. So I'll just do one commit per feature, and I'll give you a simple summary.

This is the summary of changes I promised, so that you can understand what I did without looking at the commits. Also, I'll keep updating this when I make new commits if there's anything worth mentioning, so that it's it's easier to not get confused. :wink:

Something to take into account. Most of the features that I implemented are not possible without the re-write, so asking me to not push the re-write is impossible. :smiley:

I re-wrote the whole thing basically, improving it's structure and making it more lightweight.
- I improved it's structure in a way that makes more sense, only loading it when it's needed, the workflow of the plugin is easier and smarter.
- Made it lightweight in the way that it now is only loaded when it is on, or called on. And when it is off by default, or it is called off, it will completely unload anything that the plugin created or was using, thus making it more lightweight when not in use.
Added system to recognize file types easily and do special things with each file type.
- Added recognition system for [Command Line] buffers, in order to only use permanent line numbers on them.
- Added recognition system for [Vundle] Installer buffers, in order to only use permanent line numbers on them, since you may want to know how many plugins you're using.
Added method to disable numbertoggle by default, until called on, which solves issue #5.
Line number's width don't jump around when changing line numbers mode, thanks to @ClementJunca.
Added a method to specify the mode in which numbertoggle should be on by default whenever turned off or when off by default. Solving the issue #5 even better.
Added way to call numbertoggle, on/off, from one to the other, with no problems.
Added invert mode, which does the same but opposite effects (insert mode has relative numbers, normal mode has permanent numbers, etc.).
Improved practically non existent documentation.
- Made the Vim docs for numbertoggle follow Vim's standards, making them info full with the Vim help format.
- Improved numbertoggle's README file in order to show almost the same info as docs, but be prettier.
- Improved the README file adding a Vundle installation section.
Fixed a couple of bugs, mostly made by me and the one expressed in issue #6.

That's the summary, so that you can take it all in, the commits don't matter. :wink:

Note that the original pull request started on the 1b6fe6b commit, anything after that are patch commits. Patch commits don't matter, they're just bug fixes and stuff like that kind of patch commits. :wink:

greduan commented 11 years ago

@jeffkreeftmeijer I finished this I think. I have added everything I was planning on adding and I think it's pretty much full featured now. If you want you can analyze the code and find any improvements, if you want.

BTW, @markus1189 any thoughts on this pull request? Any way it could be improved?

greduan commented 11 years ago

@jeffkreeftmeijer Just a friendly bump. It's been almost two weeks since last comment. And almost a month since the pull request.

If what you need is time just say so. :wink:

greduan commented 11 years ago

@markus1189, do you have any comments on this? Any way it could be improved?

greduan commented 11 years ago

@jeffkreeftmeijer It's been over a month I opened this pull request... You think you could look into it?

erikrw commented 11 years ago

Perhaps my #11 "feature request" could become part of your version? I hope you see a way to do it efficiently!

jeffkreeftmeijer commented 11 years ago

@Greduan did you get the e-mail I sent you a while back via the contact form on your website? The email address from your Github profile bounced, so I tried it that way.

I'm closing this as I'm not pulling this in right now. There are some good things in here, but I'd love to work with Eduan to get them out into separate pull requests.

greduan commented 11 years ago

@erikrw It was actually already implemented into my pull request. But I think your way of doing it is more efficient, so I'm using your method instead. :wink:

@jeffkreeftmeijer I did not get the email yet. I do remember getting an empty email with no subject line or anything, perhaps it was that one, but the form works correctly. :/

Could you try sending an email to eduan@snapsimpletech.com again? See if it works this time. :wink:

jeffkreeftmeijer commented 11 years ago

@Greduan I tried sending you the e-mail last week and today, but it bounced again. Do you have another e-mail address I can send it to?

greduan commented 11 years ago

@jeffkreeftmeijer Yes, you can try sending it to eduanlavaque@gmail.com.

I figured out that for some reason my other account's email is down or something. I'm gonna try fixing that. :)

jeffkreeftmeijer / vim-numbertoggle

Re wrote the plugin in order to have more functionality and be more efficient #10