search

jefflai108 / Contrastive-Predictive-Coding-PyTorch

Contrastive Predictive Coding for Automatic Speaker Verification
MIT License
472 stars 96 forks source link

NCE accuracy calculation #14

Closed JaejinCho closed 8 months ago

JaejinCho commented 4 years ago

Hello @jefflai108,

I think the accuracy also should have its denominator as batch*self.timestep at https://github.com/jefflai108/Contrastive-Predictive-Coding-PyTorch/blob/a9dab4e759aaa68dce1b1ada46a8035076ba3296/src/model/model.py#L320

Possibly for other models too although I did not check them.

colinator commented 3 years ago

Yes, and it should be correct += I believe, just above there...