Closed janhartmann closed 5 years ago
It's suffices to modify:
export interface FetchMock extends jest.MockInstance<any> {
to:
export interface FetchMock extends jest.MockInstance<any,any[]> {
and depend on "@types/jest": "^23.3.14",
That way you can avoid having to upgrade your requirements to Jest 24 (which can go in some other PR).
Agreed, hold on.
@jefflau Any chance we can get this merged + released?
Ill have a look tomorrow! If its not in tomorrow, nudge me again. Itβs chinese new year so things are a little hectic!
From: Kevin Centeno notifications@github.com Sent: Friday, February 8, 2019 1:50:18 AM To: jefflau/jest-fetch-mock Cc: Jeff Lau; Mention Subject: Re: [jefflau/jest-fetch-mock] Updated Jest and Jest Types (#106)
@jefflauhttps://github.com/jefflau Any chance we can get this merged + released?
β You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jefflau/jest-fetch-mock/pull/106#issuecomment-461529375, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABKiFWngThi1VLgyOsVbdHdN91_A8jCbks5vLGdagaJpZM4ai0RE.
Ah, no worries! π π
Cheers @jefflau - enjoy it! π
Hey @kevcenteno would you please check/merge the fix? :D
@ma581 it isn't my repo... Ping @jefflau
@jefflau will you be able to release this anytime soon?
Sorry for the wait. I gotta pretty sick just after the new year and haven't had a chance to merge. I'm going to merge now.
Adjusted breaking change of generic signature of
MockInstance
:https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jest/index.d.ts#L810